fix(multipart): ensure BodyPartReader.read() returns bytes not bytearray#12414
Closed
armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
Closed
fix(multipart): ensure BodyPartReader.read() returns bytes not bytearray#12414armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
Conversation
The read() method built its result in a bytearray but returned it directly, violating the documented return type of bytes. This caused TypeError when passing the result to json.dumps() or other APIs that expect bytes but not bytearray.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
documents its return type as
bytes, but internally builds the result in abytearrayand returns it directly. This means callers receive abytearrayinstead ofbytes, which breaks code that passes the result tojson.dumps()or other APIs that don't acceptbytearray.Reproduction
From #12404:
Fix
Convert the internal
bytearraytobytesbefore returning fromread(). This is a minimal, backward-compatible change —bytes(bytearray)is a no-op copy for the common case.Fixes #12404