Migrate WebMCP surface to document.modelContext (Promise registration, single-arg execute)#23
Merged
Merged
Conversation
naji247
approved these changes
Jun 23, 2026
Member
|
Version bump? |
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step of bringing the polyfill and hooks in line with the current WebMCP spec. This PR is the structural surface migration:
registerToolreturns aPromise<undefined>that rejects on invalid input (empty / duplicate / over-128-char or illegal name, missing description orexecute, non-serializableinputSchema, non–potentially-trustworthyexposedToorigin). Internal tool-change notifications now fan out to multiple listeners.unregisterToolis gone — pass{ signal }toregisterTooland abort it to remove the tool.useMcpToolwires this up on cleanup.navigator.modelContexttodocument.modelContext(the spec moved the getter toDocument). Native detection is document-only; the testing API stays onnavigator.modelContextTesting.execute/handlerare single-argument. TheModelContextClientsecond argument (andrequestUserInteraction) is removed.These are breaking changes. The version bump, CHANGELOG, and doc updates land in a follow-up PR once the rest of the migration is in.
Test plan
pnpm typecheck— cleanpnpm lint— cleanpnpm test— 163 passing (Vitest + jsdom, incl. StrictMode)pnpm build