Tool descriptor updates, toolchange event, and registration error handling#24
Merged
Merged
Conversation
…; add top-level title
…wnership; harden schemaFingerprint
naji247
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the
document.modelContextmigration (#23). Updates the tool descriptor to the current spec shape, adds thetoolchangeevent, and makes registration error handling robust:{ readOnlyHint?, untrustedContentHint? }and a top-leveltitleadded to the tool config/descriptor (the classicdestructiveHint/idempotentHint/openWorldHintandannotations.titleare dropped, matching the spec).exposedTo?: string[]is forwarded from the tool config toregisterTool, and the tool re-registers when it changes.toolchangeevent ondocument.modelContext(now anEventTarget) — supportsaddEventListener('toolchange', …)and anontoolchangehandler. Notifications fan out to the testing shim and the event dispatcher.onError(AbortError from teardown is ignored). Ownership uses compare-and-set so a duplicate-name registration can't evict the existing owner.schemaFingerprintis hardened against non-serializable schemas so a bad schema can't throw during render.Test plan
pnpm typecheck— cleanpnpm lint— cleanpnpm test— 171 passing (Vitest + jsdom, incl. StrictMode double-mount + duplicate-name ownership)pnpm build