Fix the 4 dead *_changed flow triggers#12
Merged
Conversation
allow_export_changed, backup_reserve_changed, operation_mode_changed, and steering_wheel_heater_changed were declared as flow trigger cards but nothing ever called them, so flows built on them silently never ran. update() now fires the matching device trigger card with the new value whenever one of these capabilities actually changes.
This was referenced Jul 22, 2026
Bre77
added a commit
that referenced
this pull request
Jul 22, 2026
…, remove dead onoff.defrost config (#14) The four dead *_changed flow triggers (allow_export, backup_reserve, operation_mode, steering_wheel_heater) were already fixed in #12, but the regression test only exercised backup_reserve and steering_wheel_heater directly. Add explicit fire/no-fire tests for allow_export_changed and operation_mode_changed so all four declared triggers are covered individually. Also remove the orphaned onoff.defrost capabilitiesOptions block in the vehicle driver compose - the capability was never added to the driver's capabilities array, so this config was dead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
*_changedflow triggers so they actually fire:allow_export_changed,backup_reserve_changed,operation_mode_changed,steering_wheel_heater_changed.homeycompose/flow/triggers/but nothing ever calls.trigger()on them.TeslemetryDevice.update()only callssetCapabilityValue, so a flow built on any of these cards silently never runsupdate()now fires the matching device trigger card with the new value as its token whenever one of these four capabilities actually changes (old value != new value), so unrelated polling/SSE updates that leave the value unchanged don't spam the flowtest/capability-change-triggers.test.ts) proving a changed value fires the matching card with the right token, an unchanged value doesn't fire it, and capabilities with no declared trigger card never fire one