Round out dead trigger fix: full test coverage + drop dead onoff.defrost config#14
Merged
Conversation
…, remove dead onoff.defrost config The four dead *_changed flow triggers (allow_export, backup_reserve, operation_mode, steering_wheel_heater) were already fixed in #12, but the regression test only exercised backup_reserve and steering_wheel_heater directly. Add explicit fire/no-fire tests for allow_export_changed and operation_mode_changed so all four declared triggers are covered individually. Also remove the orphaned onoff.defrost capabilitiesOptions block in the vehicle driver compose - the capability was never added to the driver's capabilities array, so this config was dead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
*_changedflow triggers (allow_export_changed,backup_reserve_changed,operation_mode_changed,steering_wheel_heater_changed)update()already fires the matching trigger card on a real value change; the regression test only exercisedbackup_reserveandsteering_wheel_heaterdirectlyallow_export_changedandoperation_mode_changedso all 4 declared triggers have direct coverage, not just the shared mechanismonoff.defrostcapabilitiesOptionsblock fromdrivers/vehicle/driver.compose.jsoncapabilitiesarray, so the title config was dead