i18n(de): recover @bluemoon288's German translations + Admin/Media keys#110
Open
telivity-otaip wants to merge 2 commits into
Open
i18n(de): recover @bluemoon288's German translations + Admin/Media keys#110telivity-otaip wants to merge 2 commits into
telivity-otaip wants to merge 2 commits into
Conversation
Extends i18n coverage to the surfaces added since the i18n foundation (#105): the Admin/RBAC user + role management panels and the media/photo gallery. - en.json: new `admin.*` (33 keys) and `media.*` (13 keys) namespaces - de.json: matching empty stubs (fall back to English) for translation - Migrate UserSettings, RolesSettings (+ sub-components RoleChecklist, EditRoles, PermissionMatrix) and MediaGallery to t() - Interpolation for "Roles — {{name}}" and "{{count}} permissions" - Data-driven strings (permission group names/labels from the API) left as-is Verified: dashboard typecheck clean, 43/43 tests pass, build OK. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Restores the German dashboard translations contributed by @bluemoon288 in PR #107, which was closed before merging. nav + header strings are now translated; admin/media keys remain as stubs for the next pass. Co-authored-by: bluemoon288 <[email protected]> Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Collaborator
Author
|
` @bluemoon288 Good news — your translations are recovered and already in PR #110, credited to you. You don't need to redo any of that. The only thing left is the difference: the new Admin (Users & Roles) and Media gallery screens. In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the German (
de) locale up to date and lays out the remaining work for the newer feature areas. Combines:nav+header(from PR Update de.json #107, which was closed before it merged — his work was not lost). His commit is co-authored to him.t(), withadmin.*/media.*keys inen.jsonand empty German stubs ready to translate.This supersedes #109 (which contained only part 2).
Status of the German locale
admin.*(Users & Roles) andmedia.*(photo gallery) keys — currently empty inde.json, so they safely fall back to English until filled in.For @bluemoon288 — what's next (the new models)
If you'd like to continue, the next batch to translate in
apps/dashboard/src/locales/de.json:admin.*— the Users & Roles / RBAC admin panel (table headers, buttons like Add User / Create Role, status labels,"Roles — {{name}}","{{count}} permissions")media.*— the property/room photo gallery (Primary, Set as primary, Upload a file, captions, etc.)Same as before: fill the values in
de.json, leave anything uncertain empty (it falls back to English), preview with the EN/DE header switcher.Notes
His translations are restored as he wrote them. A few optional refinements worth a look (not blocking):
ratePlans"Raten Pläne" → "Ratenpläne",foliosBilling"Rechnungstellung" → "Rechnungsstellung",notifications"Nachrichten" → "Benachrichtigungen".Verification
de.jsonvalid JSON; dashboard typecheck + 43/43 tests + build all pass (from the included migration commit).🤖 Generated with Claude Code