feat(dashboard): i18n for Admin (Users & Roles) + Media gallery#109
Closed
telivity-otaip wants to merge 1 commit into
Closed
feat(dashboard): i18n for Admin (Users & Roles) + Media gallery#109telivity-otaip wants to merge 1 commit into
telivity-otaip wants to merge 1 commit into
Conversation
Extends i18n coverage to the surfaces added since the i18n foundation (#105): the Admin/RBAC user + role management panels and the media/photo gallery. - en.json: new `admin.*` (33 keys) and `media.*` (13 keys) namespaces - de.json: matching empty stubs (fall back to English) for translation - Migrate UserSettings, RolesSettings (+ sub-components RoleChecklist, EditRoles, PermissionMatrix) and MediaGallery to t() - Interpolation for "Roles — {{name}}" and "{{count}} permissions" - Data-driven strings (permission group names/labels from the API) left as-is Verified: dashboard typecheck clean, 43/43 tests pass, build OK. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Collaborator
Author
|
Superseded by #110, which includes this admin/media migration plus @bluemoon288's recovered German translations from #107 in one coherent PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends i18n coverage to the dashboard surfaces added since the i18n foundation (#105): the Admin / RBAC panels (Users & Roles) and the Media / photo gallery. These shipped in #108 with hardcoded English; this wires them to
react-i18nextand adds the keys.Changes
en.json: newadmin.*(33 keys) andmedia.*(13 keys) namespaces — source of truthde.json: matching keys as empty stubs (fall back to English until translated) — ready for the German contributor (@bluemoon288)t():components/admin/UserSettings.tsx(+ sub-componentsRoleChecklist,EditRoles)components/admin/RolesSettings.tsx(+PermissionMatrix)components/media/MediaGallery.tsxadmin.rolesForUser→ "Roles — {{name}}",admin.permissionsCount→ "{{count}} permissions"Scope
Strings-only migration of the three new components. No behavior change. Other pages remain on the incremental migration path.
Verification
pnpm --filter @telivityhaip/dashboard typecheck— cleanpnpm --filter @telivityhaip/dashboard test— 43/43 passpnpm --filter @telivityhaip/dashboard build— OK🤖 Generated with Claude Code