Skip to content

Potential fix for code scanning alert no. 21: Clear-text logging of sensitive information #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnteee merged 1 commit into from
May 25, 2026
Merged

Potential fix for code scanning alert no. 21: Clear-text logging of sensitive information #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions teaagent/cli/_handlers/_doctor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,29 @@ def _is_sensitive_key(key: str) -> bool:
return any(marker in normalized for marker in _SENSITIVE_KEY_MARKERS)


def _redact_sensitive_fields(value: Any) -> Any:
def _redact_sensitive_fields(
value: Any, known_sensitive_values: set[str] | None = None
) -> Any:
if known_sensitive_values is None:
known_sensitive_values = set()

if isinstance(value, dict):
redacted: dict[Any, Any] = {}
for k, v in value.items():
key_str = str(k)
if _is_sensitive_key(key_str):
if isinstance(v, str) and v:
known_sensitive_values.add(v)
redacted[k] = _REDACTED
else:
redacted[k] = _redact_sensitive_fields(v)
redacted[k] = _redact_sensitive_fields(v, known_sensitive_values)
return redacted
if isinstance(value, list):
return [_redact_sensitive_fields(item) for item in value]
return [
_redact_sensitive_fields(item, known_sensitive_values) for item in value
]
if isinstance(value, str) and value in known_sensitive_values:
return _REDACTED
return value


Expand Down
Loading