Potential fix for code scanning alert no. 21: Clear-text logging of sensitive information#25
Merged
Merged
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
johnteee
marked this pull request as ready for review
May 25, 2026 02:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TeaEntityLab/teaAgent/security/code-scanning/21
Best fix: strengthen sanitization before logging so that known secret-like values are redacted even when they are not under sensitive-looking keys.
In
teaagent/cli/_handlers/_doctor.py, update_redact_sensitive_fieldsto support a contextual pass of sensitive values discovered under sensitive keys, and then redact matching scalar occurrences anywhere else in the payload. This preserves existing behavior while closing the gap that CodeQL tracks fromchecks['api_token']toprint_json. No functional behavior changes besides safer output.Concretely:
_redact_sensitive_fieldssignature to carry an optionalknown_sensitive_valuesset._REDACTED._REDACTED.print_jsoncan remain as-is (safe_value = _redact_sensitive_fields(value)), since default set creation happens in the function.No new dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.