Skip to content

fix(docker): update gateway download URL and fix npm install command for adapters #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olamide226 merged 1 commit into from
Feb 26, 2026
Merged

fix(docker): update gateway download URL and fix npm install command for adapters #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 40 additions & 21 deletions .github/workflows/release-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,17 @@ jobs:
recover-stale-releases:
name: Recover Stale Releases
runs-on: ubuntu-latest
if: github.event_name == 'push'
# Runs on every trigger but steps are conditioned on push events.
# This ensures the job always succeeds (never "skipped"), so downstream

Copilot AI Feb 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says this job “always succeeds”, but on push the Create missing manifest tags... step can still fail (e.g. git push / GH API errors), which will fail the job and block downstream jobs. Either reword this to “not skipped on workflow_dispatch” (the key behavior change), or explicitly set continue-on-error: true for the recovery step if the intent is to never block releases.

Suggested change
# This ensures the job always succeeds (never "skipped"), so downstream
# This ensures the job is not skipped on workflow_dispatch, so downstream

Copilot uses AI. Check for mistakes.
# jobs can depend on it without if: always() — which breaks output propagation.
steps:
- uses: actions/checkout@v4
if: github.event_name == 'push'
with:
fetch-depth: 0

- name: Create missing manifest tags and relabel stale PRs
if: github.event_name == 'push'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
Expand Down Expand Up @@ -106,7 +110,7 @@ jobs:
name: Release Please
runs-on: ubuntu-latest
needs: recover-stale-releases
if: always() # run even if recover-stale-releases was skipped (workflow_dispatch)
if: ${{ !cancelled() }}
outputs:
releases_created: ${{ steps.resolve.outputs.releases_created }}
paths_released: ${{ steps.resolve.outputs.paths_released }}
Expand Down Expand Up @@ -148,22 +152,37 @@ jobs:
- name: Resolve outputs
id: resolve
run: |
set -euo pipefail

if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
GATEWAY_TAG="${{ inputs.gateway_tag }}"
GATEWAY_RELEASE_CREATED=$([[ -n "$GATEWAY_TAG" ]] && echo "true" || echo "")
NPM_PUBLISH=$([[ "${{ inputs.republish_npm }}" == "true" ]] && echo "true" || echo "")
RELEASES_CREATED=$([[ -n "$GATEWAY_RELEASE_CREATED" || -n "$NPM_PUBLISH" ]] && echo "true" || echo "")
echo "releases_created=${RELEASES_CREATED}" >> "$GITHUB_OUTPUT"
echo "paths_released=" >> "$GITHUB_OUTPUT"
echo "gateway_release_created=${GATEWAY_RELEASE_CREATED}" >> "$GITHUB_OUTPUT"
echo "gateway_tag_name=${GATEWAY_TAG}" >> "$GITHUB_OUTPUT"
echo "npm_publish=${NPM_PUBLISH}" >> "$GITHUB_OUTPUT"
if [[ -n "$GATEWAY_TAG" ]]; then GATEWAY_RELEASE_CREATED="true"; else GATEWAY_RELEASE_CREATED=""; fi
if [[ "${{ inputs.republish_npm }}" == "true" ]]; then NPM_PUBLISH="true"; else NPM_PUBLISH=""; fi
if [[ -n "$GATEWAY_RELEASE_CREATED" || -n "$NPM_PUBLISH" ]]; then RELEASES_CREATED="true"; else RELEASES_CREATED=""; fi

{
echo "releases_created=${RELEASES_CREATED}"
echo "paths_released="
echo "gateway_release_created=${GATEWAY_RELEASE_CREATED}"
echo "gateway_tag_name=${GATEWAY_TAG}"
echo "npm_publish=${NPM_PUBLISH}"
} >> "$GITHUB_OUTPUT"

echo "::notice::workflow_dispatch — npm_publish=${NPM_PUBLISH}, gateway_release_created=${GATEWAY_RELEASE_CREATED}, gateway_tag=${GATEWAY_TAG}"
else
echo "releases_created=${{ steps.release.outputs.releases_created }}" >> "$GITHUB_OUTPUT"
echo "paths_released=${{ steps.release.outputs.paths_released }}" >> "$GITHUB_OUTPUT"
echo "gateway_release_created=${{ steps.release.outputs['gateway--release_created'] }}" >> "$GITHUB_OUTPUT"
echo "gateway_tag_name=${{ steps.release.outputs['gateway--tag_name'] }}" >> "$GITHUB_OUTPUT"
echo "npm_publish=${{ steps.release.outputs.releases_created }}" >> "$GITHUB_OUTPUT"
# All npm packages use linked-versions, so sdk is representative.
# No fallback to releases_created — that includes gateway-only releases.
NPM_PUBLISH="${{ steps.release.outputs['sdk--release_created'] }}"

{
echo "releases_created=${{ steps.release.outputs.releases_created }}"
echo "paths_released=${{ steps.release.outputs.paths_released }}"
echo "gateway_release_created=${{ steps.release.outputs['gateway--release_created'] }}"
echo "gateway_tag_name=${{ steps.release.outputs['gateway--tag_name'] }}"
echo "npm_publish=${NPM_PUBLISH}"
} >> "$GITHUB_OUTPUT"

echo "::notice::push — releases_created=${{ steps.release.outputs.releases_created }}, npm_publish=${NPM_PUBLISH}, gateway=${{ steps.release.outputs['gateway--release_created'] }}"
fi

publish-npm:
Expand Down Expand Up @@ -197,7 +216,7 @@ jobs:
run: |
V=$(node -p "require('./package.json').version")
PUBLISHED=$(npm view @rep-protocol/sdk@${V} version 2>/dev/null || true)
if [ "$PUBLISHED" = "$V" ]; then echo "sdk@${V} already published, skipping."; else npm publish --provenance --access public; fi
if [ "$PUBLISHED" = "$V" ]; then echo "sdk@${V} already published, skipping."; else pnpm publish --provenance --access public --no-git-checks; fi
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand All @@ -206,7 +225,7 @@ jobs:
run: |
V=$(node -p "require('./package.json').version")
PUBLISHED=$(npm view @rep-protocol/cli@${V} version 2>/dev/null || true)
if [ "$PUBLISHED" = "$V" ]; then echo "cli@${V} already published, skipping."; else npm publish --provenance --access public; fi
if [ "$PUBLISHED" = "$V" ]; then echo "cli@${V} already published, skipping."; else pnpm publish --provenance --access public --no-git-checks; fi
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand All @@ -215,7 +234,7 @@ jobs:
run: |
V=$(node -p "require('./package.json').version")
PUBLISHED=$(npm view @rep-protocol/codemod@${V} version 2>/dev/null || true)
if [ "$PUBLISHED" = "$V" ]; then echo "codemod@${V} already published, skipping."; else npm publish --provenance --access public; fi
if [ "$PUBLISHED" = "$V" ]; then echo "codemod@${V} already published, skipping."; else pnpm publish --provenance --access public --no-git-checks; fi
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand All @@ -224,7 +243,7 @@ jobs:
run: |
V=$(node -p "require('./package.json').version")
PUBLISHED=$(npm view @rep-protocol/react@${V} version 2>/dev/null || true)
if [ "$PUBLISHED" = "$V" ]; then echo "react@${V} already published, skipping."; else npm publish --provenance --access public; fi
if [ "$PUBLISHED" = "$V" ]; then echo "react@${V} already published, skipping."; else pnpm publish --provenance --access public --no-git-checks; fi
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand All @@ -233,7 +252,7 @@ jobs:
run: |
V=$(node -p "require('./package.json').version")
PUBLISHED=$(npm view @rep-protocol/vue@${V} version 2>/dev/null || true)
if [ "$PUBLISHED" = "$V" ]; then echo "vue@${V} already published, skipping."; else npm publish --provenance --access public; fi
if [ "$PUBLISHED" = "$V" ]; then echo "vue@${V} already published, skipping."; else pnpm publish --provenance --access public --no-git-checks; fi
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand All @@ -242,7 +261,7 @@ jobs:
run: |
V=$(node -p "require('./package.json').version")
PUBLISHED=$(npm view @rep-protocol/svelte@${V} version 2>/dev/null || true)
if [ "$PUBLISHED" = "$V" ]; then echo "svelte@${V} already published, skipping."; else npm publish --provenance --access public; fi
if [ "$PUBLISHED" = "$V" ]; then echo "svelte@${V} already published, skipping."; else pnpm publish --provenance --access public --no-git-checks; fi
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand Down
7 changes: 4 additions & 3 deletions examples/todo-react/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ARG TARGETARCH=amd64
RUN apk add --no-cache curl ca-certificates && \
ARCHIVE="rep-gateway_${GATEWAY_VERSION}_linux_${TARGETARCH}.tar.gz" && \
curl -fsSL \
"https://github.com/RuachTech/rep/releases/download/gateway/v${GATEWAY_VERSION}/${ARCHIVE}" \
"https://github.com/RuachTech/rep/releases/download/v${GATEWAY_VERSION}/${ARCHIVE}" \

Copilot AI Feb 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gateway download URL no longer matches the repo’s gateway tag/release naming. Gateway releases are tagged as gateway/vX.Y.Z (see gateway/.goreleaser.yml and gateway/README.md), so /releases/download/v${GATEWAY_VERSION}/... will 404 unless the gateway tagging scheme was also changed. Please align this URL with the actual gateway tag used for releases (or update the release/tag strategy consistently across the repo).

Suggested change
"https://github.com/RuachTech/rep/releases/download/v${GATEWAY_VERSION}/${ARCHIVE}" \
"https://github.com/RuachTech/rep/releases/download/gateway/v${GATEWAY_VERSION}/${ARCHIVE}" \

Copilot uses AI. Check for mistakes.
-o /tmp/gateway.tar.gz && \
tar -xzf /tmp/gateway.tar.gz -C /tmp && \
mv /tmp/rep-gateway /rep-gateway && \
Expand All @@ -35,8 +35,9 @@ FROM node:20-alpine AS app
WORKDIR /app

# Copy package files and install dependencies from npm registry.
COPY package.json package-lock.json* ./
RUN npm install
COPY package.json ./
# install on main deps only,
RUN npm install --omit=dev
Comment on lines +39 to +40

Copilot AI Feb 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install --omit=dev will omit build tooling (e.g. vite, typescript, @vitejs/plugin-react), but this stage runs npm run build which depends on those devDependencies. This will cause the Docker build to fail. Install devDependencies in the build stage (default behavior) and rely on the final FROM scratch stage to keep the runtime image minimal.

Suggested change
# install on main deps only,
RUN npm install --omit=dev
RUN npm install

Copilot uses AI. Check for mistakes.

# Copy source and build.
COPY . .
Expand Down