fix(docker): update gateway download URL and fix npm install command for adapters - #17
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the example Docker build and the release workflow to better align with current release/publishing behavior (gateway binary download + npm package publishing).
Changes:
- Update the REP gateway download URL used by the
examples/todo-reactDocker build stage. - Modify the example’s dependency installation command during Docker builds.
- Adjust the release workflow so
recover-stale-releasesisn’t skipped onworkflow_dispatch, refine output resolution, and switch package publishing topnpm publish.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
examples/todo-react/Dockerfile |
Updates gateway download URL and changes dependency install flags for the React example build stage. |
.github/workflows/release-sdk.yml |
Changes job/step conditions, hardens output resolution shell, and publishes npm packages via pnpm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| runs-on: ubuntu-latest | ||
| if: github.event_name == 'push' | ||
| # Runs on every trigger but steps are conditioned on push events. | ||
| # This ensures the job always succeeds (never "skipped"), so downstream |
There was a problem hiding this comment.
The comment says this job “always succeeds”, but on push the Create missing manifest tags... step can still fail (e.g. git push / GH API errors), which will fail the job and block downstream jobs. Either reword this to “not skipped on workflow_dispatch” (the key behavior change), or explicitly set continue-on-error: true for the recovery step if the intent is to never block releases.
| # This ensures the job always succeeds (never "skipped"), so downstream | |
| # This ensures the job is not skipped on workflow_dispatch, so downstream |
| ARCHIVE="rep-gateway_${GATEWAY_VERSION}_linux_${TARGETARCH}.tar.gz" && \ | ||
| curl -fsSL \ | ||
| "https://github.com/RuachTech/rep/releases/download/gateway/v${GATEWAY_VERSION}/${ARCHIVE}" \ | ||
| "https://github.com/RuachTech/rep/releases/download/v${GATEWAY_VERSION}/${ARCHIVE}" \ |
There was a problem hiding this comment.
The gateway download URL no longer matches the repo’s gateway tag/release naming. Gateway releases are tagged as gateway/vX.Y.Z (see gateway/.goreleaser.yml and gateway/README.md), so /releases/download/v${GATEWAY_VERSION}/... will 404 unless the gateway tagging scheme was also changed. Please align this URL with the actual gateway tag used for releases (or update the release/tag strategy consistently across the repo).
| "https://github.com/RuachTech/rep/releases/download/v${GATEWAY_VERSION}/${ARCHIVE}" \ | |
| "https://github.com/RuachTech/rep/releases/download/gateway/v${GATEWAY_VERSION}/${ARCHIVE}" \ |
| # install on main deps only, | ||
| RUN npm install --omit=dev |
There was a problem hiding this comment.
npm install --omit=dev will omit build tooling (e.g. vite, typescript, @vitejs/plugin-react), but this stage runs npm run build which depends on those devDependencies. This will cause the Docker build to fail. Install devDependencies in the build stage (default behavior) and rely on the final FROM scratch stage to keep the runtime image minimal.
| # install on main deps only, | |
| RUN npm install --omit=dev | |
| RUN npm install |
No description provided.