Skip to content

build(deps): drop support for Python 3.8#307

Merged
joanise merged 2 commits into
mainfrom
dev.ej/drop-py-38
Jun 8, 2026
Merged

build(deps): drop support for Python 3.8#307
joanise merged 2 commits into
mainfrom
dev.ej/drop-py-38

Conversation

@joanise

@joanise joanise commented Jun 5, 2026

Copy link
Copy Markdown
Member

PR Goal?

Python 3.8 is long EOL, and it prevents us from using uv lock on Windows. There is no value in keeping it anymore, so let's drop it.

Feedback sought?

confirmation we don't need Python 3.8 support anymore

Priority?

normal

Tests added?

all well covered

Confidence?

high

Version change?

no

Related PR

NRC-ILT/g2p#492

@joanise joanise requested a review from roedoejet June 5, 2026 18:47
@semanticdiff-com

semanticdiff-com Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  tests/test_g2p_cli.py  100% smaller
  tests/test_make_xml_cli.py  100% smaller
  .github/workflows/matrix-tests.yml  15% smaller
  README.md Unsupported file format
  pyproject.toml Unsupported file format
  readalongs/__init__.py  0% smaller

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
CLI load time: 0:00.04
Pull Request HEAD: c515851a30690a66965c6e79d7cc6abd2e57b301
No imports take more than 0.1 s.

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.76%. Comparing base (19c9b25) to head (c515851).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          21       21           
  Lines        1765     1765           
  Branches      295      295           
=======================================
  Hits         1655     1655           
  Misses         73       73           
  Partials       37       37           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roedoejet roedoejet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good thanks @joanise

@joanise joanise merged commit 0f47bc8 into main Jun 8, 2026
8 checks passed
@joanise joanise deleted the dev.ej/drop-py-38 branch June 8, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants