Skip to content

build: drop Python 3.8 support and testing#492

Merged
joanise merged 3 commits into
mainfrom
dev.ej/drop-py-38
Jun 8, 2026
Merged

build: drop Python 3.8 support and testing#492
joanise merged 3 commits into
mainfrom
dev.ej/drop-py-38

Conversation

@joanise

@joanise joanise commented Jun 5, 2026

Copy link
Copy Markdown
Member

PR Goal?

Python 3.8 is long EOL, and it prevents us from using uv lock on Windows. There is no value in keeping it anymore, so let's drop it.

Feedback sought?

confirmation we don't need Python 3.8 support anymore

Priority?

normal

Tests added?

all well covered

Confidence?

high

Version change?

not required, but I would like to publish 2.3.2 soon with the recent dependency changes, this drop of 3.8, and the requirements.txt refresh in #493

Related PR

ReadAlongs/Studio#307

@joanise joanise requested a review from roedoejet June 5, 2026 18:17
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@roedoejet roedoejet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it's fine to drop 3.8 now. thanks @joanise

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
CLI load time: 0:00.08
Pull Request HEAD: f6c77d0355668ada80d0555a9151b4551342b613
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

@joanise joanise merged commit f194a9c into main Jun 8, 2026
9 of 10 checks passed
@joanise joanise deleted the dev.ej/drop-py-38 branch June 8, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants