Skip to content

Fix: Default jazzy needs: image suffix to cuda13.2 #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaur-k wants to merge 1 commit into
base: v9.4
Choose a base branch
from
Open

Fix: Default jazzy needs: image suffix to cuda13.2 #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,16 @@ jobs:
// in v0.9.0 / PR #37) — so the suffix must live in `image_ref`.
//
// example_ws runs integration jazzy-only (humble is disabled), so the
// map carries only `jazzy`. The default is the CONSERVATIVE legacy
// suffix (-cuda12.6-cudnn9), NOT the newest CUDA the Jazzy migration
// targets: moveit_pro owns the distro<->CUDA coupling (its build-matrix
// exclusion anchors) and is the single source of truth. On a
// repository_dispatch it overrides the per-distro value from its
// payload once it publishes a divergent suffix (#19583). To re-enable
// humble: add a `humble` entry here AND to integration-test's
// `ros_distro` matrix.
let gpu_image_suffixes = { jazzy: '-cuda12.6-cudnn9' };
// map carries only `jazzy`. The default must track what moveit_pro
// actually publishes for jazzy: since the CUDA 13.2 migration
// (#19583 fanout), jazzy images carry -cuda13.2-cudnn9 ONLY — the
// old -cuda12.6 jazzy variant is no longer built, so a stale default
// 404s every `needs:` pull. moveit_pro owns the distro<->CUDA
// coupling (its build-matrix exclusion anchors) and is the single
// source of truth: on a repository_dispatch its payload overrides
// this value. To re-enable humble: add a `humble` entry here AND to
// integration-test's `ros_distro` matrix.
let gpu_image_suffixes = { jazzy: '-cuda13.2-cudnn9' };
Comment thread
coderabbitai[bot] marked this conversation as resolved.
// The single ros_distro example_ws runs integration on — must match
// the `integration-test` matrix / `ros_distros` input below. The
// suffix is selected for THIS distro. If humble is ever re-enabled,
Expand Down
Loading