Fix: Default jazzy needs: image suffix to cuda13.2#707
Open
shaur-k wants to merge 1 commit into
Open
Conversation
|
Consider whether the change should land upstream in Overlapping files
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe CI workflow's ChangesCI GPU Image Suffix Update
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 111-120: The default GPU image suffix was changed to
'-cuda13.2-cudnn9' for the jazzy key in gpu_image_suffixes which may not match
actual Docker Hub tags and can 404; revert or update gpu_image_suffixes.jazzy to
the exact tag pattern used by the workflow (e.g., the main-jazzy-<arch>-...
naming convention) or add a runtime guard/fallback that checks for tag existence
before pulling (and falls back to the previous known-good suffix or skips the
job), and update the adjacent comment that claims CUDA 13.2-only publication to
accurately reflect the true published tags and any repository_dispatch override
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ae9e7fab-12cf-4d6a-8eef-b6530bbbc79f
📒 Files selected for processing (1)
.github/workflows/ci.yaml
Since the CUDA 13.2 migration, moveit_pro publishes jazzy images with the -cuda13.2-cudnn9 suffix only; the conservative -cuda12.6 default made every pull_request needs: run 404 on a tag that is no longer built. The repository_dispatch path is unaffected (payload overrides). Co-Authored-By: Claude Opus 4.8 <[email protected]>
shaur-k
force-pushed
the
claude/needs-gpu-suffix-cuda13
branch
from
ecbef28 to
24c3199
Compare
|
|
JWhitleyWork
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs: moveit_pro/#19732
Motivation
Every
pull_requestrun with aneeds: moveit_pro/#Ntoken currently 404s at container init: the resolve step's default jazzy GPU suffix is-cuda12.6-cudnn9, but since the CUDA 13.2 migration moveit_pro publishes jazzy images with-cuda13.2-cudnn9only — the cuda12.6 jazzy tag is no longer built.Brief description
Bump the resolve step's default
gpu_image_suffixesjazzy entry to-cuda13.2-cudnn9and update the comment: the default must track what moveit_pro actually publishes, not a "conservative legacy" value that no longer exists. Therepository_dispatchpath is unaffected — moveit_pro's payload (GPU_IMAGE_SUFFIXES, moveit_proci.yaml:514) already overrides this default.How it was tested
actionlint+ pre-commit clean.needs:token above points this PR's own integration run at moveit_pro #19732's jazzy image, which exists only under the cuda13.2 suffix — the run itself validates the fix end-to-end.