Skip to content

fix(adapter-evm): skip release-trap changeset guard when changeset is consumed #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasevin merged 1 commit into from
Jul 17, 2026
Merged

fix(adapter-evm): skip release-trap changeset guard when changeset is consumed #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 39 additions & 31 deletions packages/adapter-evm/test/sf-5-published-release.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* (covered by SF-1–SF-4 suites).
*/
import { execFileSync, execSync } from 'node:child_process';
import { mkdtempSync, readdirSync, readFileSync, rmSync } from 'node:fs';
import { existsSync, mkdtempSync, readdirSync, readFileSync, rmSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { dirname, join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
Expand Down Expand Up @@ -87,36 +87,44 @@ function assertUiTypesFloor(manifest: PackageManifest, packageLabel: string): vo
}

describe('SF-5 published release correctness', () => {
describe('INV-R1 · RELEASE-TRAP GUARD — dual-package changeset', () => {
it('lists @openzeppelin/adapter-evm with a semver bump (public npm target)', () => {
const content = readFileSync(CHANGESET_PATH, 'utf8');
const frontmatter = parseChangesetFrontmatter(content);
expect(
frontmatter['@openzeppelin/adapter-evm'],
'INV-R1: adapter-evm must be bumped — core-only changeset leaves npm consumers on stale 2.2.0 (002 trap)'
).toBeTruthy();
});

it('lists @openzeppelin/adapter-evm-core with a semver bump (private bundled source)', () => {
const content = readFileSync(CHANGESET_PATH, 'utf8');
const frontmatter = parseChangesetFrontmatter(content);
expect(
frontmatter['@openzeppelin/adapter-evm-core'],
'INV-R1: adapter-evm-core must be bumped in lockstep — workspace truth must match bundled bits'
).toBeTruthy();
});

it('does not ship a core-only changeset (adapter-evm absent)', () => {
const content = readFileSync(CHANGESET_PATH, 'utf8');
const frontmatter = parseChangesetFrontmatter(content);
const publicBump = frontmatter['@openzeppelin/adapter-evm'];
const coreBump = frontmatter['@openzeppelin/adapter-evm-core'];
expect(
publicBump && coreBump,
`INV-R1: both packages required; got adapter-evm=${publicBump ?? 'MISSING'}, adapter-evm-core=${coreBump ?? 'MISSING'}`
).toBeTruthy();
});
});
// The release-trap guard is a pre-merge check on the pending changeset. On the
// changeset-release branch `changeset version` has already consumed (deleted) the
// changeset and applied the version bumps, so the file is absent — skip here (the
// release is the proof). The floor + bundled-tarball probes below still validate the
// shipped delta on both feature and release branches.
describe.skipIf(!existsSync(CHANGESET_PATH))(
'INV-R1 · RELEASE-TRAP GUARD — dual-package changeset',
() => {
it('lists @openzeppelin/adapter-evm with a semver bump (public npm target)', () => {
const content = readFileSync(CHANGESET_PATH, 'utf8');
const frontmatter = parseChangesetFrontmatter(content);
expect(
frontmatter['@openzeppelin/adapter-evm'],
'INV-R1: adapter-evm must be bumped — core-only changeset leaves npm consumers on stale 2.2.0 (002 trap)'
).toBeTruthy();
});

it('lists @openzeppelin/adapter-evm-core with a semver bump (private bundled source)', () => {
const content = readFileSync(CHANGESET_PATH, 'utf8');
const frontmatter = parseChangesetFrontmatter(content);
expect(
frontmatter['@openzeppelin/adapter-evm-core'],
'INV-R1: adapter-evm-core must be bumped in lockstep — workspace truth must match bundled bits'
).toBeTruthy();
});

it('does not ship a core-only changeset (adapter-evm absent)', () => {
const content = readFileSync(CHANGESET_PATH, 'utf8');
const frontmatter = parseChangesetFrontmatter(content);
const publicBump = frontmatter['@openzeppelin/adapter-evm'];
const coreBump = frontmatter['@openzeppelin/adapter-evm-core'];
expect(
publicBump && coreBump,
`INV-R1: both packages required; got adapter-evm=${publicBump ?? 'MISSING'}, adapter-evm-core=${coreBump ?? 'MISSING'}`
).toBeTruthy();
});
}
);

describe('FLOOR CORRECTNESS — @openzeppelin/ui-types ^3.3.0', () => {
it('adapter-evm declares ui-types ^3.3.0 in peerDependencies and devDependencies', () => {
Expand Down
Loading