fix(adapter-evm): skip release-trap changeset guard when changeset is consumed#57
Merged
Merged
Conversation
… consumed The SF-5 INV-R1 guard read the pending changeset by a fixed path, which `changeset version` deletes on the changeset-release branch — making the release PR CI fail with ENOENT even though the release is correct. Gate the guard on the changeset file's presence: it runs (and enforces the dual-package bump) on feature branches, and skips on the release branch where the changeset has already been consumed. The ui-types floor and bundled-tarball (V-1..V-7) probes still validate the shipped delta on both. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
changeset-release/mainrelease PR (#56) CI failed on Test — 3 failures inpackages/adapter-evm/test/sf-5-published-release.test.ts(INV-R1 RELEASE-TRAP GUARD):The guard reads the pending changeset by a fixed path.
changeset versionconsumes (deletes) that changeset on the release branch, so the assertions blow up even though the release is correct. Feature PR #55 passed because the changeset is still present there.Fix
Gate the INV-R1 guard block with
describe.skipIf(!existsSync(CHANGESET_PATH)):adapter-evm+adapter-evm-core) — the 002 release-trap protection is intact.The
ui-types ^3.3.0floor probe and the bundled-tarball V-1..V-7 marker probes still run on both branches, so the shipped delta remains verified end-to-end.Test plan
pnpm --filter @openzeppelin/adapter-evm run typecheck— greenpnpm --filter @openzeppelin/adapter-evm run lint+ prettier — greenMade with Cursor