contracts RFC - alternate implementation using generated options#500287
Closed
KiaraGrouwstra wants to merge 12 commits into
Closed
contracts RFC - alternate implementation using generated options#500287KiaraGrouwstra wants to merge 12 commits into
KiaraGrouwstra wants to merge 12 commits into
Conversation
18 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
e39e587 to
4f5c076
Compare
Signed-off-by: cinereal <[email protected]>
Signed-off-by: cinereal <[email protected]>
Signed-off-by: cinereal <[email protected]>
e253418 to
963f8fc
Compare
Signed-off-by: cinereal <[email protected]>
Signed-off-by: cinereal <[email protected]>
Signed-off-by: cinereal <[email protected]>
Signed-off-by: cinereal <[email protected]>
Signed-off-by: cinereal <[email protected]>
963f8fc to
1e35a8b
Compare
Signed-off-by: cinereal <[email protected]>
Contributor
Author
|
while this PR was somewhat modest, i've since been on a more invasive reimagining of this making for a nicer API and accounting for use with modular services. i feel like, given the API changes, pushing that here would go against the more humble spirit of this PR, so i'll try and prepare a new one instead. |
This was referenced Apr 3, 2026
Contributor
Author
|
as promised: #506343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for contracts (NixOS/rfcs#189), using a
fileSecretscontract as an example.This iteration is similar to the earlier:
configuse within typesfileSecrets, and built on top of by the current PR to address its duplicationFeedback welcome!
In particular:
types.optionTypehad a.merge, I tried to look for a method that might work with an API that's somewhat more plain.config, resulting in the currentevalOptionconstruct to be able to use the module system there still.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.