lib.types: add types.option#499945
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/6555 |
|
🤨 With great power comes great responsibility! Could you document this? And maybe add something that we generally prefer to avoid this type because it's a form of metaprogramming, making it harder to reason about a module. (For context, not sure if that's applicable here, but I vehemently oppose the practice of "undocumenting" questionable features, which is subjective in the first place. If someone thinks it's questionable, that means they have something useful to say in the docs!) |
02fe7db to
6f3888c
Compare
Signed-off-by: cinereal <[email protected]>
6f3888c to
7334dd9
Compare
|
I wonder why a |
|
this type i'd hoped for for #500287. |
i noticed that while we had a
types.optionType, describing what goes into a module systemtype, we seemingly did not yet have a type to describe an actual module system option itself.this change fills that gap.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.