Skip to content

🎨 Palette: [UX improvement] #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yeboster wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🎨 Palette: [UX improvement] #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@

**Learning:** Async buttons that handle errors often fail to reset their error state on subsequent attempts. This leads to a confusing UX where a successful retry still displays the error icon, making the user believe the action failed again.
**Action:** Always ensure that error flags (e.g., `hasError`) are reset at the _start_ of the async operation, not just set in the `catch` block.

## 2024-11-06 - Accessible Trailing Icons in SMUI Textfields
**Learning:** Trailing icons in input fields (like clear buttons) should be conditionally rendered to prevent users from focusing on an empty action. Furthermore, dynamically binding `withTrailingIcon` to the same condition ensures layout consistency in SMUI components.
**Action:** Always conditionally render trailing interactive elements in input fields based on the input's value and use descriptive `aria-label`s instead of generic ones like "cancel".
16 changes: 9 additions & 7 deletions src/routes/profile/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

if (trimmedDomain.startsWith(trimmedSearch) || trimmedDomain.includes(trimmedSearch))
return true;
else false;
else return false;
}
</script>

Expand All @@ -55,14 +55,16 @@
label="Search"
bind:value={search}
variant="outlined"
withTrailingIcon
withTrailingIcon={search !== ''}
>
<svelte:fragment slot="trailingIcon">
<div class="close-icon">
<IconButton on:click={cleanSearch} aria-label="cancel">
<Icon icon="cancel" />
</IconButton>
</div>
{#if search !== ''}
<div class="close-icon">
<IconButton on:click={cleanSearch} aria-label="clear search">
<Icon icon="cancel" />
</IconButton>
</div>
{/if}
</svelte:fragment>
</Textfield>
<DomainsTable domains={domainsFiltered} {loaded} />
Expand Down