🎨 Palette: [UX improvement]#382
Conversation
Conditionally rendered the clear search button and its layout spacing when there is an active search to prevent unnecessary tab stops. Updated the aria label to be more descriptive. Co-authored-by: yeboster <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: I conditionally rendered the "clear search" trailing icon in the domain search
Textfieldso that it only appears and takes up space when the user actually types something. I also updated its aria-label from a generic "cancel" to a descriptive "clear search".🎯 Why: Currently, the close icon is always rendered, meaning users tabbing through the interface can focus on it and attempt to clear an empty search field, which is a confusing and slightly broken experience.
📸 Before/After: Before: Cancel icon is visibly interactive on empty state. After: Clean search field until input.
♿ Accessibility: I removed an empty focus trap (actionable button with no purpose) and updated the
aria-labelto properly describe the button's action. I also updated thewithTrailingIconattribute dynamically to maintain SMUI's layout boundaries.PR created automatically by Jules for task 18084020956277354914 started by @yeboster