Skip to content

🎨 Palette: Conditional trailing icon in Profile search #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yeboster wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🎨 Palette: Conditional trailing icon in Profile search #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@

**Learning:** Async buttons that handle errors often fail to reset their error state on subsequent attempts. This leads to a confusing UX where a successful retry still displays the error icon, making the user believe the action failed again.
**Action:** Always ensure that error flags (e.g., `hasError`) are reset at the _start_ of the async operation, not just set in the `catch` block.
## 2024-11-20 - Ensure trailing clear icon buttons correctly hide for empty fields and resets reactive lists

**Learning:** When using reactive lists in Svelte filtering based on text inputs (like an autocomplete search string binding logic), the user may get stuck if the search is empty but the bound list is not reset or when the clear icon button is clicked. Moreover, unconditionally rendering trailing "clear search" icons in an empty text field breaks keyboard accessibility as the icon still receives focus without having an action or state to revert.
**Action:** Always conditionally render both the HTML elements representing the trailing icons (e.g. `{#if search !== ''}`) and set dynamic boolean props on parent inputs (e.g. `withTrailingIcon={search !== ''}`). When setting up reactive statements targeting input strings, guarantee that the empty string edge cases reset their mapped list by writing explicitly handled fallbacks.
18 changes: 11 additions & 7 deletions src/routes/profile/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

$: if (search !== '') {
domainsFiltered = domains.filter((domain) => isFuzzyMatch(domain.name, search));
} else {
domainsFiltered = domains;
}

walletAddress.subscribe(async (address) => {
Expand All @@ -39,7 +41,7 @@

if (trimmedDomain.startsWith(trimmedSearch) || trimmedDomain.includes(trimmedSearch))
return true;
else false;
else return false;
}
</script>

Expand All @@ -55,14 +57,16 @@
label="Search"
bind:value={search}
variant="outlined"
withTrailingIcon
withTrailingIcon={search !== ''}
>
<svelte:fragment slot="trailingIcon">
<div class="close-icon">
<IconButton on:click={cleanSearch} aria-label="cancel">
<Icon icon="cancel" />
</IconButton>
</div>
{#if search !== ''}
<div class="close-icon">
<IconButton on:click={cleanSearch} aria-label="clear search">
<Icon icon="cancel" />
</IconButton>
</div>
{/if}
</svelte:fragment>
</Textfield>
<DomainsTable domains={domainsFiltered} {loaded} />
Expand Down