Skip to content

🎨 Palette: Conditional trailing icon in Profile search#376

Draft
yeboster wants to merge 1 commit into
mainfrom
palette-conditional-trailing-icon-8700421162489458780
Draft

🎨 Palette: Conditional trailing icon in Profile search#376
yeboster wants to merge 1 commit into
mainfrom
palette-conditional-trailing-icon-8700421162489458780

Conversation

@yeboster

Copy link
Copy Markdown
Contributor

💡 What:

  • Conditionally hides the clear search icon in the Profile domains search bar when the input is empty.
  • Resets the domainsFiltered reactive list to the original domains list when the search input gets cleared.
  • Updates the trailing icon's aria-label from "cancel" to "clear search" for better clarity.

🎯 Why:

  • Without this change, keyboard users could tab to the focusable "clear search" button even when there was no search string to clear, resulting in an inaccessible ghost element state.
  • When the search string was cleared, the filtered list was not correctly reset to the whole collection.

Accessibility:

  • Changed IconButton aria-label from generic "cancel" to a descriptive "clear search".
  • Hidden elements from the tab order when input is empty.

PR created automatically by Jules for task 8700421162489458780 started by @yeboster

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 25, 2026 8:30pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant