Skip to content

[WIP] Fix failing shellcheck GitHub Actions job #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoannaaKL merged 2 commits into from
May 27, 2026
Merged

[WIP] Fix failing shellcheck GitHub Actions job #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9124e52
Initial plan
Copilot May 27, 2026
a8d4e6c
fix: resolve shellcheck warnings in install script
Copilot May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,23 @@ install_fonts(){
local dest="$HOME/.local/share/fonts"
mkdir -p "$dest"
# Detect existing Meslo Nerd Font via glob
(
if (
shopt -s nullglob nocaseglob 2>/dev/null || true
local meslo_candidates=("$dest"/*Meslo*"Nerd Font"*.ttf)
if (( ${#meslo_candidates[@]} > 0 )); then
log "Meslo Nerd Font already present"
exit 0
fi
)
if [[ $? -eq 0 ]]; then
); then
Comment on lines +46 to +53
return 0
fi
local tmp_zip
tmp_zip="$(mktemp)"
if curl -fsSL -o "$tmp_zip" https://github.com/ryanoasis/nerd-fonts/releases/latest/download/Meslo.zip; then
unzip -oq "$tmp_zip" -d "$dest"
command -v fc-cache >/dev/null && fc-cache -f >/dev/null 2>&1 || true
if command -v fc-cache >/dev/null 2>&1; then
fc-cache -f >/dev/null 2>&1 || true
fi
log "Fonts installed"
else
warn "Font download failed; skipping"
Expand Down
Loading