[WIP] Fix failing shellcheck GitHub Actions job - #11
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates install.sh to address ShellCheck findings from the failing shellcheck GitHub Actions job.
Changes:
- Replaces indirect
$?checking with anif (...)compound command. - Rewrites the
fc-cachecommand chain as an explicitifblock.
Show a summary per file
| File | Description |
|---|---|
install.sh |
Updates font-installation logic to satisfy ShellCheck style warnings. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+46
to
+53
| if ( | ||
| shopt -s nullglob nocaseglob 2>/dev/null || true | ||
| local meslo_candidates=("$dest"/*Meslo*"Nerd Font"*.ttf) | ||
| if (( ${#meslo_candidates[@]} > 0 )); then | ||
| log "Meslo Nerd Font already present" | ||
| exit 0 | ||
| fi | ||
| ) | ||
| if [[ $? -eq 0 ]]; then | ||
| ); then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.