monitoring: filtrar grabaciones por un grupo de extensiones por usuario#64
Open
trixocom wants to merge 1 commit into
Open
monitoring: filtrar grabaciones por un grupo de extensiones por usuario#64trixocom wants to merge 1 commit into
trixocom wants to merge 1 commit into
Conversation
The monitoring module honours acl_user.monitorexten (via paloACL) for non-reportany users, filtering recordings to a list of extensions with IN(). The userlist 'extension' plugin gains a field to edit the list. Backward compatible: a single extension yields the same result as the previous '=' filter. Bumps release 5 -> 6. Requires the companion framework PR that adds the column and ACL helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
¡Hola Nico! 👋 Soy Hector, de Trixocom. Esta es la segunda mitad de la feature; la primera (columna + helpers en
paloACL) va en IssabelFoundation/framework#33.Qué hace
Para usuarios sin privilegio
reportany, el módulomonitoringahora filtra las grabaciones por la listaacl_user.monitorexten(víapaloACL::getUserMonitorExtensions()), usandoIN(...)sobresrc/dst/ canal. Si el usuario no tiene lista cargada, cae a su extensión propia (comportamiento clásico). El pluginextensiondeuserlistagrega el campo "Extensiones a monitorear" para editarla desde la UI.Así, un supervisor puede ver las grabaciones de un grupo de internos (su equipo) sin ver las de toda la central y sin necesidad de
reportany.Compatibilidad
Total hacia atrás: una sola extensión produce exactamente el mismo resultado que el filtro
=anterior. Lo verificamos sobre datos reales de un cliente en producción:viejo (= 592)==nuevo IN(592)(mismos conteos)IN(592,518)== unión de 592 y 518 (mismos conteos)Depende de
IssabelFoundation/framework#33 (agrega la columna
acl_user.monitorexteny los helpers enpaloACL).El bump de release (5→6) lo podés descartar si manejás los releases por tu lado.
¡Gracias y un abrazo!
— Hector / Trixocom