ACL: lista opcional de extensiones a monitorear por usuario (acl_user.monitorexten)#33
Open
trixocom wants to merge 1 commit into
Open
Conversation
Adds acl_user.monitorexten plus getUserMonitorExtensions()/setUserMonitorExtensions() in paloACL so a user can be scoped to a group of extensions in the recordings monitor. Backward compatible: empty/missing column keeps classic behaviour. Bumps release 3 -> 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
¡Hola Nico! 👋 Soy Hector, de Trixocom.
Nos surgió la necesidad de que ciertos usuarios puedan ver, en el módulo de Grabaciones (
monitoring), no solo su propia extensión ni todas, sino un grupo de extensiones. Esta es la primera mitad de la feature (ladoframework); la segunda va en un PR apbxque usa estos helpers.Qué agrega
acl_user.monitorexten(lista de extensiones separada por comas) en el schema de instalación (setup/db/install/acl/1_schema.sql).paloACL::getUserMonitorExtensions($username)→ devuelve un arreglo de extensiones (vacío si no hay).paloACL::setUserMonitorExtensions($username, $list).Compatibilidad
100% hacia atrás. Si la columna está vacía —o no existe en instalaciones que no migraron—
getUserMonitorExtensions()devuelve un arreglo vacío y todo sigue funcionando como antes (el consumidor cae a la extensión propia del usuario).Nota de migración
Para instalaciones existentes hace falta:
No agregué un archivo
update_sqlversionado porque no quise asumir el esquema de versionado de la rama 5.x. Decime cómo preferís encajar la migración y lo ajusto.El bump de release (3→4) lo podés descartar si manejás los releases por tu lado.
PR companion (lo consume): IssabelFoundation/pbx#64
¡Un abrazo!
— Hector / Trixocom