mlengine: remove deprecated google_ml_engine_model for 8.0.0 - #18681
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
6720873 to
c69d94f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c69d94f: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Errors
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 72 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
|
@modular-magician reassign-reviewer @malhotrasagar2212 |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
malhotrasagar2212
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
b98c3a9
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0
Remove the deprecated
google_ml_engine_modelresource and product for 8.0.0.Fixes hashicorp/terraform-provider-google#22249