agents: add major release deprecation and removal workflows - #18671
agents: add major release deprecation and removal workflows#18671c2thorn wants to merge 4 commits into
Conversation
…al-auditor subagent
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 708e45b: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
…nd add issue labeler checklist
…e removal workflows with data sources
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0f0850c: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| custom_agent: | ||
| system_prompt_sections: | ||
| - title: "Role & Persona" | ||
| content: "You are a Senior Terraform Provider Engineer specializing in major release scoping, deprecation verification, and removal dependency analysis in Magic Modules." |
There was a problem hiding this comment.
Are role assignments still effective? I thought current gen models made them mostly superfluous.
There was a problem hiding this comment.
you're correct, the are largely superfluous. it was just picked up since our older subagent specs have them.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a22c2d6: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
3 participants
This PR introduces structured workflows and a dedicated subagent for managing major release deprecations and removals in Magic Modules:
deprecate_resource_or_field: Handles establishing forward-compatibility and adding deprecation notices on themainbranch.major_release_removal: Handles executing breaking removals on a major release feature branch (FEATURE-BRANCH-major-release-X.0.0), updating the upgrade guide, and verifying downstream builds and tests.removal-auditorsubagent: Performs pre-flight audits of deprecation/replacement readiness onmain, checks major release branch sync status, and scans all codebase layers (YAMLs, templates, samples, tests, TGC converters) to produce a comprehensive removal blast-radius report..agents/WORKFLOWS.md(including GitHub label routing) and added references in.agents/knowledge/index.md.This workflow was successfully used on the following PRs:
deprecate google_beyondcorp_app_* resources and data sources(targetingmain)beyondcorp: remove deprecated google_beyondcorp_app_* for 8.0.0(targetingFEATURE-BRANCH-major-release-8.0.0)vertexai: remove deprecated google_vertex_ai_schedule for 8.0.0(targetingFEATURE-BRANCH-major-release-8.0.0)remove deprecated interconnect_attachment_group.attachment(targetingFEATURE-BRANCH-major-release-8.0.0)iap: remove deprecated google_iap_brand and google_iap_client(targetingFEATURE-BRANCH-major-release-8.0.0)integrations: remove deprecated run_as_service_account(targetingFEATURE-BRANCH-major-release-8.0.0)mlengine: remove deprecated google_ml_engine_model for 8.0.0(targetingFEATURE-BRANCH-major-release-8.0.0)