Skip to content

Remove redundant schema validation in csv_push_to_kafka_activity #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rohxnn wants to merge 1 commit into from
Closed

Remove redundant schema validation in csv_push_to_kafka_activity #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions app/temporal/csv_processing_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,21 +235,6 @@ async def csv_push_to_kafka_activity(record_id: int) -> Dict[str, Any]:
schema_errors.append({"row": row_number, "problems": [f"Failed to parse generated payload: {exc}"]})
continue

# Double-check the generated event against the exact same schema
# app/kafka/consumer.py enforces at ingestion — catches a row missing
# a required field (e.g. no Session ID, now that it's no longer
# auto-generated) here, before it's ever published, rather than
# relying on the consumer to silently DLQ it later.
problems = validate_ingestion_schema(payload_dict, report_type, "create")
if problems:
schema_errors.append({
"row": row_number,
"submissionId": payload_dict.get("submissionId"),
"sessionId": payload_dict.get("sessionId"),
"problems": problems,
})
continue

payloads.append((payload_str, f"{record_id}-{len(payloads)}"))

if schema_errors:
Expand Down