Skip to content

Remove redundant schema validation in csv_push_to_kafka_activity - #6

Closed
rohxnn wants to merge 1 commit into
ELEVATE-Project:release-1.0.0from
rohxnn:release-1.0.0
Closed

Remove redundant schema validation in csv_push_to_kafka_activity#6
rohxnn wants to merge 1 commit into
ELEVATE-Project:release-1.0.0from
rohxnn:release-1.0.0

Conversation

@rohxnn

@rohxnn rohxnn commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated CSV processing so successfully decoded JSON records are published without an additional schema validation step.
    • Records that cannot be decoded as JSON continue to be skipped and reported as processing errors.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 705edc14-c482-4fda-a295-7446d98ce58b

📥 Commits

Reviewing files that changed from the base of the PR and between 0f60c2b and 0977d7a.

📒 Files selected for processing (1)
  • app/temporal/csv_processing_activity.py
💤 Files with no reviewable changes (1)
  • app/temporal/csv_processing_activity.py

Walkthrough

The CSV-to-Kafka activity no longer validates successfully decoded row payloads against the ingestion schema. JSON decoding failures continue to be recorded and skipped; decoded payloads proceed directly to Kafka publishing.

Changes

CSV Kafka validation

Layer / File(s) Summary
Decoded payload handling
app/temporal/csv_processing_activity.py
Removes per-row validate_ingestion_schema checks after JSON decoding while retaining error recording and skipping for decoding failures.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the removal of redundant schema validation in csv_push_to_kafka_activity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rohxnn rohxnn closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant