docs: Update GML_REFERENCE.md#1395
Merged
Merged
Conversation
Updated the section on built-in constants and special values, consolidating information.
Updated terminology for variable kinds and added details on static variables and methods. Enhanced explanations for context keywords 'self' and 'other'.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Added detailed explanations for context keywords 'self' and 'other' in GML, including their behavior and usage in different scenarios.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
|
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Updated the structure and content of the GML reference documentation to clarify variable scope and categories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Consolidates built-in constants and special values into one categorized table in
GML_REFERENCE.mdand removes the old Core Constants section. Reorganizes variable docs intoVariable ScopeandVariable Categorieswith clearerself/otherandstaticbehavior.Variable ScopeandVariable Categories; clarified name resolution (local → instance → global → built-in).static: top-of-function initialization/hoisting, call-once requirement before external access,static_get/static_set, inheritance read vs write rules; recommendstaticmethods in constructors with an inheritance example.selfandother.++,--), function hoisting notes, and type checks (is_method,is_callable).Written for commit 25d54ce. Summary will update on new commits.