Skip to content

feat(iOS): Enable synchronous screen shadow state updates by default #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmichalikk merged 3 commits into from
Apr 28, 2026
Merged

feat(iOS): Enable synchronous screen shadow state updates by default #3931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea0897f
feat: Enable synchronous screen shadow state updates by default
kmichalikk Apr 23, 2026
0a8846a
remove unnecessary comment
kmichalikk Apr 23, 2026
eee2e5e
Fix Test2543
kmichalikk Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FabricExample/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import App from '../apps';
import { featureFlags } from 'react-native-screens';

featureFlags.experiment.synchronousScreenUpdatesEnabled = false;
featureFlags.experiment.synchronousScreenUpdatesEnabled = true;
featureFlags.experiment.synchronousHeaderConfigUpdatesEnabled = true;
featureFlags.experiment.synchronousHeaderSubviewUpdatesEnabled = true;
featureFlags.experiment.androidResetScreenShadowStateOnOrientationChangeEnabled =
Expand Down
3 changes: 0 additions & 3 deletions apps/src/tests/issue-tests/Test2543.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ function FormSheet({ route }: StackNavigationProp) {
</Text>
<View
style={{
flex: 1,
alignItems: 'center',
justifyContent: 'center',
height: 180,
Expand All @@ -100,7 +99,6 @@ function FormSheet({ route }: StackNavigationProp) {
</View>
<View
style={{
flex: 1,
alignItems: 'center',
justifyContent: 'center',
height: 180,
Expand All @@ -112,7 +110,6 @@ function FormSheet({ route }: StackNavigationProp) {
</View>
<View
style={{
flex: 1,
alignItems: 'center',
justifyContent: 'center',
height: 200,
Expand Down
1 change: 1 addition & 0 deletions ios/RNSScreen.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ - (void)initCommonProps
_sheetsScrollView = nil;
_sheetContentHeight = 0.0;
_markedForUnmountInCurrentTransaction = NO;
_synchronousShadowStateUpdatesEnabled = YES;
Comment thread
kmichalikk marked this conversation as resolved.
}

+ (RNSViewInteractionManager *)viewInteractionManagerInstance
Expand Down
2 changes: 1 addition & 1 deletion src/fabric/ModalScreenNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export interface NativeProps extends ViewProps {
leftScrollEdgeEffect?: CT.WithDefault<ScrollEdgeEffect, 'automatic'>;
rightScrollEdgeEffect?: CT.WithDefault<ScrollEdgeEffect, 'automatic'>;
topScrollEdgeEffect?: CT.WithDefault<ScrollEdgeEffect, 'automatic'>;
synchronousShadowStateUpdatesEnabled?: CT.WithDefault<boolean, false>;
synchronousShadowStateUpdatesEnabled?: CT.WithDefault<boolean, true>;
}

export default codegenNativeComponent<NativeProps>('RNSModalScreen', {
Expand Down
2 changes: 1 addition & 1 deletion src/fabric/ScreenNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export interface NativeProps extends ViewProps {
leftScrollEdgeEffect?: CT.WithDefault<ScrollEdgeEffect, 'automatic'>;
rightScrollEdgeEffect?: CT.WithDefault<ScrollEdgeEffect, 'automatic'>;
topScrollEdgeEffect?: CT.WithDefault<ScrollEdgeEffect, 'automatic'>;
synchronousShadowStateUpdatesEnabled?: CT.WithDefault<boolean, false>;
synchronousShadowStateUpdatesEnabled?: CT.WithDefault<boolean, true>;
androidResetScreenShadowStateOnOrientationChangeEnabled?: CT.WithDefault<
boolean,
true
Expand Down
2 changes: 1 addition & 1 deletion src/flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const RNS_SYNCHRONOUS_SCREEN_STATE_UPDATES_DEFAULT = false;
const RNS_SYNCHRONOUS_SCREEN_STATE_UPDATES_DEFAULT = true;
const RNS_SYNCHRONOUS_HEADER_CONFIG_STATE_UPDATES_DEFAULT = true;
const RNS_SYNCHRONOUS_HEADER_SUBVIEW_STATE_UPDATES_DEFAULT = true;
const RNS_ANDROID_LEGACY_TOP_INSET_BEHAVIOR_DEFAULT = false;
Expand Down
Loading