feat(iOS): Enable synchronous screen shadow state updates by default#3931
Merged
kmichalikk merged 3 commits intomainfrom Apr 28, 2026
Merged
feat(iOS): Enable synchronous screen shadow state updates by default#3931kmichalikk merged 3 commits intomainfrom
kmichalikk merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables synchronous screen shadow state updates by default (via synchronousScreenUpdatesEnabled = true) to improve iOS behavior for Fabric/native stack scenarios that benefit from immediate state propagation.
Changes:
- Flips the default for
synchronousScreenUpdatesEnabledtotruein the JS feature flags. - Updates Fabric codegen defaults so
synchronousShadowStateUpdatesEnableddefaults totrueforRNSScreenandRNSModalScreen. - Sets the iOS native screen view’s internal default (
_synchronousShadowStateUpdatesEnabled) toYES.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/flags.ts | Changes the JS feature flag default to enable synchronous screen updates by default. |
| src/fabric/ScreenNativeComponent.ts | Updates Fabric codegen default prop for synchronous shadow state updates on RNSScreen. |
| src/fabric/ModalScreenNativeComponent.ts | Updates Fabric codegen default prop for synchronous shadow state updates on RNSModalScreen. |
| ios/RNSScreen.mm | Sets the native iOS default for _synchronousShadowStateUpdatesEnabled to enabled. |
| FabricExample/App.tsx | Aligns the example app’s flag configuration with the new default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
t0maboro
approved these changes
Apr 24, 2026
kkafar
approved these changes
Apr 27, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
b435347 to
eee2e5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default value for
synchronousScreenUpdatesEnabledflag totrueChanges
Updated default values for the flag in native hierarchy & JS.
Before & after - visual documentation
N/A
Test plan
See #3282
Checklist