Skip to content

feat(tvOS): bump min. deployment target to 15.1 #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkafar merged 1 commit into from
Apr 11, 2025
Merged

feat(tvOS): bump min. deployment target to 15.1 #2863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion RNScreens.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ package = JSON.parse(File.read(File.join(__dir__, "package.json")))

new_arch_enabled = ENV['RCT_NEW_ARCH_ENABLED'] == '1'
min_supported_ios_version = new_arch_enabled ? "15.1" : "15.1"
min_supported_tvos_version = "15.1"
Copy link
Copy Markdown
Contributor

@maciekstosio maciekstosio Apr 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need new_arch_enabled ? (...) above?

Copy link
Copy Markdown
Member Author

@kkafar kkafar Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I justified it in description of: #2799

min_supported_visionos_version = "1.0"
source_files = new_arch_enabled ? 'ios/**/*.{h,m,mm,cpp}' : ["ios/**/*.{h,m,mm}", "cpp/RNScreensTurboModule.cpp", "cpp/RNScreensTurboModule.h"]

Pod::Spec.new do |s|
Expand All @@ -16,7 +18,7 @@ Pod::Spec.new do |s|
s.homepage = "https://github.com/software-mansion/react-native-screens"
s.license = "MIT"
s.author = { "author" => "[email protected]" }
s.platforms = { :ios => min_supported_ios_version, :tvos => "11.0", :visionos => "1.0" }
s.platforms = { :ios => min_supported_ios_version, :tvos => min_supported_tvos_version, :visionos => min_supported_visionos_version }
s.source = { :git => "https://github.com/software-mansion/react-native-screens.git", :tag => "#{s.version}" }
s.source_files = source_files
s.project_header_files = "cpp/**/*.h" # Don't expose C++ headers publicly to allow importing framework into Swift files
Expand Down
Loading