feat(tvOS): bump min. deployment target to 15.1#2863
Merged
Conversation
1 task
It is the lowest supported version from [email protected] onwards https://github.com/react-native-tvos/react-native-tvos?tab=readme-ov-file#general-support-for-tv
kkafar
force-pushed
the
@kkafar/deployment-target-for-tvos
branch
from
4a6a197 to
8ef1e78
Compare
maciekstosio
approved these changes
Apr 11, 2025
Contributor
maciekstosio
left a comment
maciekstosio
left a comment
There was a problem hiding this comment.
One nitpick, rest looks good
|
|
||
| new_arch_enabled = ENV['RCT_NEW_ARCH_ENABLED'] == '1' | ||
| min_supported_ios_version = new_arch_enabled ? "15.1" : "15.1" | ||
| min_supported_tvos_version = "15.1" |
Contributor
There was a problem hiding this comment.
Do we still need new_arch_enabled ? (...) above?
kkafar
added a commit
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
15.1 is the lowest supported version from
[email protected]onwards.https://github.com/react-native-tvos/react-native-tvos?tab=readme-ov-file#general-support-for-tv
Changes
Test code and steps to reproduce
N/A
This should not affect the users, unless they're not applying to our compatibility matrix.
Checklist