chore(CI): Update node version on CI, bump react-navigation and fix windows pipeline#2853
Conversation
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
I see on CI that the yarn submodules repository step is failing after the update. Do we know why is it the case?
We don't want to merge it it current state.
| PODFILE CHECKSUM: 9368f39644a8576a848701c298cb4a4fd39a41bf | ||
|
|
||
| COCOAPODS: 1.15.2 | ||
| COCOAPODS: 1.14.3 |
There was a problem hiding this comment.
I think you need to update cocoapods 😄
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
I want this commit to be included:
& please change PR title to align with conventional commit naming system.
| distribution: 'zulu' | ||
| cache: 'gradle' | ||
| - name: Use Node.js 18 | ||
| - name: Setup Node.js |
There was a problem hiding this comment.
| - name: Setup Node.js | |
| - name: Setup Node.js (version from .nvmrc) |
just a nit pick
There was a problem hiding this comment.
…react-native-windows latest version (#2857) ## Description Select `react-native version` for test project based on `react-native-windows` latest version. Sometimes, when new `react-native` version is released but `react-native-windows` is not yet available for this version, CI might fail because of the version mismatch. Now we fetch latest version of `react-native-windows` from NPM in format `x.yy.zz` and we use `x.yy` to determine latest supported version of `react-native`. Then we use it to initialize new `react-native` project. ## Changes - modify Windows CI ## Test code and steps to reproduce Windows CI ## Checklist - [x] Ensured that Windows CI passes
maciekstosio
changed the title
maciekstosio
changed the title
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Okay, we're looking good now! Let's wait for the CI before merging.
|
The e2e on old arch + Android fails independently from this PR, most likely due to slow runners. Please make sure it passes locally (cd Example && yarn build-e2e-android && yarn test-e2e-android) & we're good (provided that iOS build passes) |
|
I confirmed that old arch android passes locally |
maciekstosio
deleted the
@maciekstosio/Bump-react-navigation-to-latest-main-
branch
3 participants
Description
Update node version on CI, bump react-navigation to latest main and fix windows pipeline (#2857).
Changes
.nvmrcand use it as source of truth for GitHub workflowsChecklist