Skip to content

fix(idp): replace hardcoded issuer with external URL in IDP router #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hrntknr merged 1 commit into from
Dec 4, 2025
Merged

fix(idp): replace hardcoded issuer with external URL in IDP router #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pkg/idp/idp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ type IDPRouter struct {
authRouter *auth.AuthRouter
}

const Issuer = "mcp-oauth-proxy"

func NewIDPRouter(
repo repository.Repository,
privKey *rsa.PrivateKey,
Expand All @@ -51,7 +49,7 @@ func NewIDPRouter(
AccessTokenLifespan: 24 * time.Hour,
RefreshTokenLifespan: 30 * 24 * time.Hour,
RefreshTokenScopes: []string{},
AccessTokenIssuer: Issuer,
AccessTokenIssuer: externalURL,
EnforcePKCE: false,
EnforcePKCEForPublicClients: false,
EnablePKCEPlainChallengeMethod: true,
Expand Down Expand Up @@ -144,7 +142,7 @@ func (a *IDPRouter) handleAuthorizationReturn(c *gin.Context) {
for _, scope := range ar.GetRequestedScopes() {
ar.GrantScope(scope)
}
jwtSession, err := NewJWTSessionWithKey(Issuer, "user", a.privKey)
jwtSession, err := NewJWTSessionWithKey(a.externalURL, "user", a.privKey)
if err != nil {
a.logger.With(utils.Err(err)...).Error("Failed to create JWT session", zap.Error(err))
a.provider.WriteAuthorizeError(ctx, c.Writer, ar, err)
Expand Down Expand Up @@ -337,7 +335,7 @@ func (a *IDPRouter) handleOauthAuthorizationServer(c *gin.Context) {
}

res := &authorizationServerResponse{
Issuer: Issuer,
Issuer: a.externalURL,
AuthorizationEndpoint: authorizationEndpoint,
TokenEndpoint: tokenEndpoint,
RegistrationEndpoint: registrationEndpoint,
Expand Down
4 changes: 2 additions & 2 deletions pkg/idp/idp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func setupTestServer(t *testing.T) (*httptest.Server, repository.Repository, str
require.NoError(t, err)

logger, _ := zap.NewDevelopment()
idpRouter, err := NewIDPRouter(repo, privKey, logger, "", secret[:], authRouter)
idpRouter, err := NewIDPRouter(repo, privKey, logger, "http://localhost:8080", secret[:], authRouter)
require.NoError(t, err)

idpRouter.SetupRoutes(router)
Expand All @@ -94,7 +94,7 @@ func TestOAuthServerMetadata(t *testing.T) {
require.NoError(t, err)

// Verify OAuth server metadata
require.Equal(t, Issuer, metadata["issuer"])
require.Equal(t, "http://localhost:8080", metadata["issuer"])
authEndpoint, ok := metadata["authorization_endpoint"].(string)
require.True(t, ok)
require.Contains(t, authEndpoint, ".idp/auth")
Expand Down