fix(idp): replace hardcoded issuer with external URL in IDP router#96
Merged
fix(idp): replace hardcoded issuer with external URL in IDP router#96
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces a hardcoded issuer value with a configurable external URL in the IDP (Identity Provider) router to properly support OAuth/OIDC standards. The issuer field in OAuth/OIDC metadata must match the actual server URL to ensure token validation works correctly.
- Removed the hardcoded
Issuerconstant ("mcp-oauth-proxy") - Updated all references to use the
externalURLparameter passed toNewIDPRouter - Updated tests to reflect the new issuer value
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/idp/idp.go | Removed hardcoded Issuer constant and replaced three usages with a.externalURL field |
| pkg/idp/idp_test.go | Updated test setup to pass "http://localhost:8080" as external URL and updated assertion to expect this value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(Brief description of what this PR accomplishes)
Type of Change
Related Issues
fix #95