Add support for AssemblyFor#94
Merged
mattiaerre merged 5 commits intomasterfrom Jan 7, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 94.44% 94.46% +0.02%
==========================================
Files 5 5
Lines 234 235 +1
Branches 50 50
==========================================
+ Hits 221 222 +1
Misses 13 13
Continue to review full report at Codecov.
|
mattiaerre
reviewed
Jan 6, 2019
Member
mattiaerre
left a comment
There was a problem hiding this comment.
waiting for #92 to be fixed
|
|
||
| function forAssembly() { | ||
| assembly { | ||
| for { |
Member
There was a problem hiding this comment.
I do agree with you, this seems a little bit odd but that's a good starting point; I'll wait for you to address #92 and then we can merge both
Merged
Member
|
some conflicts that need to be resolved @fvictorio |
Member
Author
|
@mattiaerre Done! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91. Depends on #92.
I don't like how this is prettifying the fors, but at least now it won't fail when it finds them. This:
is being printed as:
I would prefer this:
(give or take).
The problem here is that the pre and post parts of the for are
AssemblyBlocks, and in most cases it makes sense to print those with a newline after the opening brace.