assembly and ast#95
Merged
mattiaerre merged 3 commits intomasterfrom Jan 7, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 94.44% 94.87% +0.42%
==========================================
Files 5 5
Lines 234 234
Branches 50 50
==========================================
+ Hits 221 222 +1
+ Misses 13 12 -1
Continue to review full report at Codecov.
|
mattiaerre
commented
Jan 6, 2019
| // eslint-disable-next-line no-unused-vars | ||
| const clean = (ast, newObj, parent) => { | ||
| ['code', 'codeStart', 'loc', 'range'].forEach(name => { | ||
| ['code', 'codeStart', 'loc', 'operations', 'range'].forEach(name => { |
Member
Author
There was a problem hiding this comment.
this is in order to bypass the problem w/ AST_COMPARE=true
Member
There was a problem hiding this comment.
This is no longer necessary. Merging master into this branch fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe
should fix #81 and #91
maybe related to #94