Conversation
Janther
commented
Mar 26, 2026
|
|
||
| print(): Doc { | ||
| return ['address', this.payableKeyword ? ' payable' : '']; | ||
| return `address${this.payableKeyword ? ' payable' : ''}`; |
Member
Author
There was a problem hiding this comment.
this one is just a bonus detail that didn't merit a PR
Janther
force-pushed
the
unneeded-path-parameters
branch
3 times, most recently
from
0927f2f to
5c8dba7
Compare
fvictorio
approved these changes
Apr 4, 2026
fvictorio
approved these changes
Apr 4, 2026
Janther
force-pushed
the
unneeded-path-parameters
branch
from
7b17a80 to
5b93368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
pathobject is the same across the whole execution, so there's no need for an internal parameter when the external parameter is still available.inspired by prettier/prettier#17867