Skip to content

Commit dd56f15

Browse files
authored
Unneeded path parameters (#1482)
* Remove unnecessary path parameters * instead of an array we can return a string for a faster print execution * setting more heap memory when linting
1 parent efd28d0 commit dd56f15

13 files changed

Lines changed: 17 additions & 20 deletions

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"build:dev": "webpack --env development",
1616
"build:test": "webpack --config webpack.test.config.js",
1717
"eslint": "eslint 'src/**' 'tests/**'",
18-
"lint": "npm run eslint && npm run prettier -- --list-different && npm run knip",
18+
"lint": "NODE_OPTIONS=\"--max-old-space-size=5120\" npm run eslint && npm run prettier -- --list-different && npm run knip",
1919
"lint:fix": "npm run eslint -- --fix && npm run prettier -- --write",
2020
"prepublishOnly": "npm run build && npx tsc",
2121
"prettier": "prettier './*.{ts,js,cjs,json,md,yml}' '{src,tests}/**/*.{ts,js,cjs}'",

src/slang-nodes/AddressType.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ export class AddressType extends SlangNode {
1717
}
1818

1919
print(): Doc {
20-
return ['address', this.payableKeyword ? ' payable' : ''];
20+
return `address${this.payableKeyword ? ' payable' : ''}`;
2121
}
2222
}

src/slang-nodes/ConstructorAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ export class ConstructorAttributes extends SlangNode {
3232
}
3333

3434
print(path: AstPath<ConstructorAttributes>, print: PrintFunction): Doc {
35-
return path.map((item) => [line, print(item)], 'items');
35+
return path.map(() => [line, print(path)], 'items');
3636
}
3737
}

src/slang-nodes/FallbackFunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ export class FallbackFunctionAttributes extends SlangNode {
3232
}
3333

3434
print(path: AstPath<FallbackFunctionAttributes>, print: PrintFunction): Doc {
35-
return path.map((item) => [line, print(item)], 'items');
35+
return path.map(() => [line, print(path)], 'items');
3636
}
3737
}

src/slang-nodes/FunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ export class FunctionAttributes extends SlangNode {
3232
}
3333

3434
print(path: AstPath<FunctionAttributes>, print: PrintFunction): Doc {
35-
return path.map((item) => [line, print(item)], 'items');
35+
return path.map(() => [line, print(path)], 'items');
3636
}
3737
}

src/slang-nodes/FunctionTypeAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ export class FunctionTypeAttributes extends SlangNode {
2727
}
2828

2929
print(path: AstPath<FunctionTypeAttributes>, print: PrintFunction): Doc {
30-
return path.map((item) => [line, print(item)], 'items');
30+
return path.map(() => [line, print(path)], 'items');
3131
}
3232
}

src/slang-nodes/ModifierAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ export class ModifierAttributes extends SlangNode {
2727
}
2828

2929
print(path: AstPath<ModifierAttributes>, print: PrintFunction): Doc {
30-
return path.map((item) => [line, print(item)], 'items');
30+
return path.map(() => [line, print(path)], 'items');
3131
}
3232
}

src/slang-nodes/ReceiveFunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ export class ReceiveFunctionAttributes extends SlangNode {
3232
}
3333

3434
print(path: AstPath<ReceiveFunctionAttributes>, print: PrintFunction): Doc {
35-
return path.map((item) => [line, print(item)], 'items');
35+
return path.map(() => [line, print(path)], 'items');
3636
}
3737
}

src/slang-nodes/StateVariableAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ export class StateVariableAttributes extends SlangNode {
2727
}
2828

2929
print(path: AstPath<StateVariableAttributes>, print: PrintFunction): Doc {
30-
return path.map((item) => [line, print(item)], 'items');
30+
return path.map(() => [line, print(path)], 'items');
3131
}
3232
}

src/slang-nodes/UnnamedFunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ export class UnnamedFunctionAttributes extends SlangNode {
3232
}
3333

3434
print(path: AstPath<UnnamedFunctionAttributes>, print: PrintFunction): Doc {
35-
return path.map((item) => [line, print(item)], 'items');
35+
return path.map(() => [line, print(path)], 'items');
3636
}
3737
}

0 commit comments

Comments
 (0)