Conversation
…in the correct place
Janther
added
comments
fvictorio
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #644
By the way, this issue originally was a bit complicated so it got fixed in the ANTLR parser just by us constantly improving the plugin. The thing was that since we fixed it without attempting to fix this issue, there were no tests associated and when we moved to Slang, there was a small regression.
UPDATE: reviewing this, I also moved the printing logic of
FunctionCallandIndexAccessinto their own file, and updated theisLabel(document)toisLabel(document, value)where not only we check for thelabeltype but also make sure that the value is the one provided since we always use it in this way.