miscelaneous: some correctness in the use or || operator

Author: Janther

src/slang-comments/handlers/handle-else-branch-comments.ts

@@ -11,7 +11,7 @@ export default function handleElseBranchComments({
   followingNode,
   comment
 }: HandlerParams): boolean {
-  if (enclosingNode?.kind !== NonterminalKind.ElseBranch || !followingNode) {
+  if (enclosingNode?.kind !== NonterminalKind.ElseBranch) {
     return false;
   }
 

src/slang-comments/handlers/handle-if-statement-comments.ts

@@ -14,7 +14,7 @@ export default function handleIfStatementComments({
   followingNode,
   comment
 }: HandlerParams): boolean {
-  if (enclosingNode?.kind !== NonterminalKind.IfStatement || !followingNode) {
+  if (enclosingNode?.kind !== NonterminalKind.IfStatement) {
     return false;
   }
 
@@ -43,7 +43,7 @@ export default function handleIfStatementComments({
     return true;
   }
 
-  if (followingNode.kind === NonterminalKind.IfStatement) {
+  if (followingNode?.kind === NonterminalKind.IfStatement) {
     if (followingNode.body.kind === NonterminalKind.Block) {
       addCollectionFirstComment(followingNode.body.statements, comment);
     } else {

src/slang-comments/handlers/handle-while-statement-comments.ts

@@ -14,10 +14,7 @@ export default function handleWhileStatementComments({
   followingNode,
   comment
 }: HandlerParams): boolean {
-  if (
-    enclosingNode?.kind !== NonterminalKind.WhileStatement ||
-    !followingNode
-  ) {
+  if (enclosingNode?.kind !== NonterminalKind.WhileStatement) {
     return false;
   }
 

src/slang-nodes/SlangNode.ts

@@ -44,7 +44,7 @@ export abstract class SlangNode {
     enclosePeripheralComments = false
   ) {
     if (ast instanceof SlangTerminalNode) {
-      const start = collected.offsets.get(ast.id) || 0;
+      const start = collected.offsets.get(ast.id) ?? 0;
       const end = start + ast.textLength.utf16;
       this.loc = {
         outerStart: start,
@@ -56,7 +56,7 @@ export abstract class SlangNode {
     }
     const cst = ast.cst;
 
-    const initialOffset = collected.offsets.get(cst.id) || 0;
+    const initialOffset = collected.offsets.get(cst.id) ?? 0;
     let offset = initialOffset;
     let triviaLength = 0;
     let leadingOffset;