feat: store information for failed block migrations#37691
feat: store information for failed block migrations#37691ChrisChV merged 11 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8e36514 to
cc1e6b0
Compare
ChrisChV
left a comment
There was a problem hiding this comment.
Looks good 👍
- I tested this: I followed the testing instructions
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
- Includes documentation
* Updates `ModulestoreBlockMigration` table to allow storing `null` values in `target` field for blocks that failed to migrate/import. * Adds `unsupported_reason` field to store reason for failure. * Add number of children blocks in failed block `unsupported_reason` field. * Fixes issue with blocks like `openassessment` where `url_name` field is not included in its olx during serialization.
Description
ModulestoreBlockMigrationtable to allow storingnullvalues intargetfield for blocks that failed to migrate/import.unsupported_reasonfield to store reason for failure.unsupported_reasonfield.openassessmentwhereurl_namefield is not included in its olx during serialization.Useful information to include:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/FAL-4269Testing instructions
See openedx/frontend-app-authoring#2703
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.