Skip to content

Commit 8e36514

Browse files
committed
chore: fix lint issues
1 parent 6776005 commit 8e36514

4 files changed

Lines changed: 17 additions & 4 deletions

File tree

cms/djangoapps/modulestore_migrator/api.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def construct_usage_key(lib_key_str: str, component: Component) -> LibraryUsageL
182182
return {
183183
obj.source.key: construct_usage_key(obj.target.learning_package.key, obj.target.component)
184184
for obj in query_set
185-
if obj.source.key is not None
185+
if obj.source.key is not None and obj.target is not None
186186
}
187187

188188

@@ -193,6 +193,10 @@ def get_migration_blocks_info(
193193
task_uuid: str | None,
194194
is_failed: bool | None,
195195
):
196+
"""
197+
Given the target key, and optional source key, target collection key, task_uuid and is_failed get a dictionary
198+
containing information about migration blocks.
199+
"""
196200
filters: dict[str, str | UUID | bool] = {
197201
'overall_migration__target__key': target_key
198202
}

cms/djangoapps/modulestore_migrator/rest_api/v1/serializers.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@
1111
from user_tasks.serializers import StatusSerializer
1212

1313
from cms.djangoapps.modulestore_migrator.data import CompositionLevel, RepeatHandlingStrategy
14-
from cms.djangoapps.modulestore_migrator.models import ModulestoreBlockMigration, ModulestoreMigration, ModulestoreSource
14+
from cms.djangoapps.modulestore_migrator.models import (
15+
ModulestoreMigration,
16+
ModulestoreSource,
17+
)
1518

1619

1720
class ModulestoreMigrationSerializer(serializers.Serializer):

cms/djangoapps/modulestore_migrator/rest_api/v1/urls.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,13 @@
44
from django.urls import include, path
55
from rest_framework.routers import SimpleRouter
66

7-
from .views import BulkMigrationViewSet, LibraryCourseMigrationViewSet, MigrationInfoViewSet, MigrationViewSet, BlockMigrationInfo
7+
from .views import (
8+
BlockMigrationInfo,
9+
BulkMigrationViewSet,
10+
LibraryCourseMigrationViewSet,
11+
MigrationInfoViewSet,
12+
MigrationViewSet,
13+
)
814

915
ROUTER = SimpleRouter()
1016
ROUTER.register(r'migrations', MigrationViewSet, basename='migrations')

cms/djangoapps/modulestore_migrator/rest_api/v1/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ def get(self, request: Request):
575575
target_key = request.query_params.get("target_key")
576576
target_collection_key = request.query_params.get("target_collection_key")
577577
task_uuid = request.query_params.get("task_uuid")
578-
is_failed = request.query_params.get("is_failed")
578+
is_failed: str | bool | None = request.query_params.get("is_failed")
579579
if not target_key:
580580
return Response({"error": "Target key cannot be blank."}, status=400)
581581
try:

0 commit comments

Comments
 (0)