fix: validation added to show Roles and permissions or course team#3023
Conversation
|
Thanks for the pull request, @jesusbalderramawgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3023 +/- ##
========================================
Coverage 95.47% 95.47%
========================================
Files 1381 1381
Lines 32563 32566 +3
Branches 7228 7472 +244
========================================
+ Hits 31088 31091 +3
+ Misses 1419 1406 -13
- Partials 56 69 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodmgwgu
left a comment
There was a problem hiding this comment.
Tested and working great, thanks!
Description
On the Settings dropdown on course overview, we see both links to "Roles and Permissions" and "Course Team". We should only see one of those depending on the flag status for that course.
Fix
validation added to show only one option on the menu depending on the flag
waffleFlags.enableAuthzCourseAuthoring