fix: validation added to show Roles and permissions or course team (#3023)

* fix: validation added to show Roles and permissions or course team

* fix: added courseId encoded to avoid issues with some chars

* fix: tests updated

Author: jesusbalderramawgu

src/header/hooks.test.tsx

@@ -108,7 +108,7 @@ describe('header utils', () => {
       });
       const actualItems =
         renderHook(() => useSettingMenuItems('course-123'), { wrapper: createWrapper() }).result.current;
-      expect(actualItems).toHaveLength(7);
+      expect(actualItems).toHaveLength(6);
     });
     it('when certificate page disabled should not include certificates option', () => {
       setConfig({
@@ -117,7 +117,7 @@ describe('header utils', () => {
       });
       const actualItems =
         renderHook(() => useSettingMenuItems('course-123'), { wrapper: createWrapper() }).result.current;
-      expect(actualItems).toHaveLength(6);
+      expect(actualItems).toHaveLength(5);
     });
     it('when user has access to advanced settings should include advanced settings option', () => {
       const actualItemsTitle = renderHook(() => useSettingMenuItems('course-123'), { wrapper: createWrapper() }).result

src/header/hooks.tsx

@@ -92,14 +92,15 @@ export const useSettingMenuItems = (courseId: string) => {
       href: `/course/${courseId}/settings/grading`,
       title: intl.formatMessage(messages['header.links.grading']),
     },
-    {
-      href: `${getConfig().ADMIN_CONSOLE_URL}/authz?scope=${courseId}`,
-      title: intl.formatMessage(messages['header.links.roles.permissions']),
-    },
-    {
-      href: `/course/${courseId}/course_team`,
-      title: intl.formatMessage(messages['header.links.courseTeam']),
-    },
+    ...(isAuthzEnabled
+      ? [{
+        href: `${getConfig().ADMIN_CONSOLE_URL}/authz?scope=${encodeURIComponent(courseId)}`,
+        title: intl.formatMessage(messages['header.links.roles.permissions']),
+      }]
+      : [{
+        href: `/course/${courseId}/course_team`,
+        title: intl.formatMessage(messages['header.links.courseTeam']),
+      }]),
     {
       href: `/course/${courseId}/group_configurations`,
       title: intl.formatMessage(messages['header.links.groupConfigurations']),