Skip to content

feat: Migrate groupsConfiguration from Redux store to ReactQuery#2980

Merged
ChrisChV merged 4 commits intoopenedx:masterfrom
open-craft:chris/redux-migration/groupConfigurations
Apr 30, 2026
Merged

feat: Migrate groupsConfiguration from Redux store to ReactQuery#2980
ChrisChV merged 4 commits intoopenedx:masterfrom
open-craft:chris/redux-migration/groupConfigurations

Conversation

@ChrisChV
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV commented Apr 3, 2026

Description

  • Migrates groupsConfiguration from Redux store to ReactQuery
  • Which user roles will this change impact? "Developer".

Supporting information

Testing instructions

  • Create a new course
  • Go to Settings > Advanced Settings. In Advanced Module List add split_test to enable the Experiment group configurations.
  • Go to Settings > Group Configuration.
  • Test Add/edit/Delete a normal group.
  • test Add/edit/delete an experiment group.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV
Copy link
Copy Markdown
Contributor Author

ChrisChV commented Apr 3, 2026

Hi @bradenmacdonald could you review this PR?

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 97.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.50%. Comparing base (3a8eb99) to head (e738952).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/saving-error-alert/utils.ts 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
+ Coverage   95.48%   95.50%   +0.01%     
==========================================
  Files        1392     1390       -2     
  Lines       32899    32843      -56     
  Branches     7585     7565      -20     
==========================================
- Hits        31415    31368      -47     
+ Misses       1415     1407       -8     
+ Partials       69       68       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Apr 6, 2026
@bradenmacdonald
Copy link
Copy Markdown
Contributor

@ChrisChV I'll be happy to review this PR but it might take me a while to get to it.

Copy link
Copy Markdown
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks so much @ChrisChV. Sorry I took so long to review here 😞. This will need a rebase.

Comment thread src/generic/saving-error-alert/SavingErrorAlert.tsx
@ChrisChV ChrisChV force-pushed the chris/redux-migration/groupConfigurations branch from 264f2a0 to b8e994e Compare April 29, 2026 23:21
@ChrisChV ChrisChV merged commit da4e81b into openedx:master Apr 30, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Apr 30, 2026
@ChrisChV ChrisChV deleted the chris/redux-migration/groupConfigurations branch April 30, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants